HTML radio buttons

From:	af (CAER)	14 Feb 2011 16:37
To:	Radio	88 of 95

38188.88 In reply to 38188.87

Ok that's easy enough - the 'Calculate grand total' lines just need to be changed to this:

javascript code:

var GrandTotal = f1 + total,
    GrandTotalW = w1 + totalWholesale;

Oh and if you want to make Truffy happy and/or stick to the standards, you can change the .innerHTML bits in the loop to .firstChild.nodeValue

edit:
Sorry, I just noticed a mistake I made earlier, too - this line:

code:

var checkBoxes = getCheckboxes,

should read:

code:

var checkBoxes = getCheckboxes(),

Note the brackets - they assign the return value of the function to the variable checkBoxes, rather than assigning it the function itself.

FORJ Forum

0/0

Reply Quote

More

From:	af (CAER)	14 Feb 2011 16:45
To:	99% of gargoyles look like (MR_BASTARD)	89 of 95

38188.89 In reply to 38188.86
That'd be fine if the checkboxes were created (by hand, I'm guessing) with a value attribute in the first place :) FORJ Forum

0/0

Reply Quote

More

From:	Radio	15 Feb 2011 10:11
To:	af (CAER)	90 of 95

38188.90 In reply to 38188.88

Still not working. I noticed one error myself, you'd referred to a variable as GrandTotalW rather than GrandWTotal, but then I got this next one:

Message: 'parentElement.previousElementSibling.innerHTML' is null or not an object
Line: 126
Char: 9
Code: 0

HTML is attached.

(by the way, this is why I prefer my method, it may be more long winded and cumbersome, but it's a damn site easier to understand and fix when it goes wrong)

My life is hard, I suffer lots

Attachments:
PL3.htm

0/0

Reply Quote

More

From:	af (CAER)	15 Feb 2011 11:05
To:	Radio	91 of 95

38188.91 In reply to 38188.90
Once again, it's an issue with IE, in this case not supporting the previousElementSibling property. Change it to previousSibling and it works fine. I've only tried it in IE8, dunno about 7 or 6. FORJ Forum

0/0

Reply Quote

More

From:	Radio	15 Feb 2011 11:17
To:	ALL	92 of 95

38188.92

I'm only worried about 8, and all seems to work fine now - thanks.

My life is hard, I suffer lots

0/0

Reply Quote

More

From:	Radio	17 Feb 2011 12:15
To:	ALL	93 of 95

38188.93

Using the function supplied earlier, some of the numbers coming in are in the thousands, and have helpfully been formatted to include comma separators.
I found a snippet of javascript that removes commas, but it doesn't seem to work. Anyone care to have a go at explaining what I've done wrong this time? ;-)

javascript code:

<script type="text/javascript">
//Get the values from the table when checkboxes are checked
var getCheckboxes = function () {
    var i, elements = document.getElementsByTagName("input"),
        max = elements.length,
        result = [];
 
    for (i = 0; i < max; i += 1) {
        if (elements[i].type === "checkbox") {
            result.push(elements[i]);
        }
    }
    return result;
    DeleteComma(result);
};

javascript code:

<script type="text/javascript">
function DeleteComma(num) {
var temp1 = 0;
var xarray = num.split(",");
if ( xarray[2] != null ) {
   temp1 = xarray[0]+xarray[1]
+xarray[2]; return temp1 } 
else if ( xarray[1] != null ) {
          temp1 = xarray[0]
+xarray[1]; return temp1}
       else
{temp1 = xarray[0]; return temp1 }         
}
</script>

My life is hard, I suffer lots

0/0

Reply Quote

More

From:	af (CAER)	17 Feb 2011 14:05
To:	Radio	94 of 95

38188.94 In reply to 38188.93

Um, that seems like a vastly over-complex function just for removing commas from a string.

javascript code:

var deleteCommas = function (num) {
    return (num + "").replace(/,/g, "");
};

But aside from that, you're calling DeleteComma() on the result of a function that generates a list of checkboxes. There are no commas to delete from such a list. Moreover, you'e calling it after the function has returned, so it never actually gets exectuted.

edit:
Looking over the code, the bit you need to change is this loop:

javascript code:

for (i = 0; i < max; i += 1) {
    if (checkBoxes[i].checked) {
        // Get values directly from table cells.
        total += +checkBoxes[i].parentElement.
            previousElementSibling.innerHTML;
        totalWholesale += +checkBoxes[i].parentElement.
            previousElementSibling.previousElementSibling.innerHTML;
    }
}

Change it to this:

javascript code:

var element, deleteCommas;
 
deleteCommas = function (num) {
    return (num + "").replace(/,/g, "");
}; 
 
for (i = 0; i < max; i += 1) {
    if (checkBoxes[i].checked) {
        element = checkBoxes[i].parentElement.previousSibling;
        total += +deleteCommas(element.innerHTML);
 
        element = element.previousSibling;
        totalWholesale += +deleteCommas(element.innerHTML);
    }
}

edit again:
Actually to make it even more resilient, you could change deleteCommas() to:

javascript code:

stripNonNumeric = function (num) {
    return (num + "").replace(/[^0-9.]/g, "");
};

That way it would remove things like currency symbols or extra spaces or whatnot - anything that isn't a digit or a .

FORJ Forum

0/0

Reply Quote

More

From:	Radio	17 Feb 2011 14:54
To:	af (CAER)	95 of 95

38188.95 In reply to 38188.94

Cheers - much appreciated once again!

My life is hard, I suffer lots

0/0

Reply Quote

More