Aye. It's a pain in the arse.

It should be NULL, not an empty string. If you var_dump the variable it'll show you what it contains.

If you turn on PHP strict error checking you'll get an undefined index error if you don't test with isset / array_key_exists. I prefer to code with strict errors switched on, it's safer and makes me feel smarter

Ah, fair enough then. And yeah, it is null when var_dumped.

I need some more database coding help.

I have a row with a list of comma separated image filenames.

eg

image1.jpg,image2.jpg,image3.jpg,image4.jpg

I generally PHP echo out the contents of a row using a nice and simple

{$row[images]}

That would obviously just chuck out the text with the commas, useless. I want each imagen.jpg wrapped in some HTML without the commas.
eg

<img src="image1.jpg" /><img src="image2.jpg" /><img src="image3.jpg" /><img src="image4.jpg" />

HOW?!

$blah = split(",", $row[images]);
foreach ($blah as $beep) {
echo "<img src=\"" . $beep . "\" />";
}

Probably a neater way which PB or Matt will come along and embarrass me with.

And how do I pop that within a current big echo?

 

I'm trying (honest :$ )

To help more, I'd like the images somewhere within this lot....

$car = $_GET['car'];

$query  = "SELECT * FROM cars WHERE carcode = '$car' ";
$result = mysql_query($query);

while($row = mysql_fetch_array($result, MYSQL_ASSOC))

echo "
<table>
    <tr>
    <th rowspan='5'><a href='#'><img src='./photos/{$row[thumb]}' /></a>
    <br />
    <td colspan='2' width='300px'><a href='car.php?car={$row[carcode]}'>{$row[title]}</a></td>
    </tr>
    <tr>
    <td width='250px'>{$row[year]}<br />
                      {$row[mileage]}<br />
                      {$row[engine]}<br />
                      {$row[fuel]}<br />
                      {$row[gearbox]}<br />     </td>
    <td width='250px'>{$row[colour]}<br />
                      {$row[mot]}<br />
                      {$row[tax]}<br /></td>
    </tr>
    <tr>
    <td colspan='2'>{$row[extra]}</td>
    </tr>
    <tr>
    <td colspan='2' align='right' valign='bottom'><b>&pound;{$row[price]}</b></td>
    </tr>
    <tr>
    <td colspan='2'>FULL WIDTH</td>
    </tr>
</table>

         ";

I think I'm doing this totally wrong, because I actually want to do some stuff with the output from the other rows depending on what it is rather than just showing their content.

 

Back to the drawing board possibly.

Indicate where in that you'd want the images. But essentially you'd do...

$blah = split(",", $row[images]);
foreach ($blah as $beep) {
$stringading .= "<img src=\"" . $beep . "\" />";
}

And then just add $stringading in where you want the images echoed. So like...

$car = $_GET['car'];

$query  = "SELECT * FROM cars WHERE carcode = '$car' ";
$result = mysql_query($query);

while($row = mysql_fetch_array($result, MYSQL_ASSOC))

echo "
<table>
    <tr>
    <th rowspan='5'><a href='#'><img src='./photos/{$row[thumb]}' /></a>
    <br />
    <td colspan='2' width='300px'><a href='car.php?car={$row[carcode]}'>{$row[title]}</a></td>
    </tr>
    <tr>
    <td width='250px'>{$row[year]}<br />
                      {$row[mileage]}<br />
                      {$row[engine]}<br />
                      {$row[fuel]}<br />
                      {$row[gearbox]}<br />     </td>
    <td width='250px'>{$row[colour]}<br />
                      {$row[mot]}<br />
                      {$row[tax]}<br /></td>" . $stringading . "

</tr>
    <tr>
    <td colspan='2'>{$row[extra]}</td>
    </tr>
    <tr>
    <td colspan='2' align='right' valign='bottom'><b>&pound;{$row[price]}</b></td>
    </tr>
    <tr>
    <td colspan='2'>FULL WIDTH</td>
    </tr>
</table>

         ";

(which is a nonsensical place to dump them but you get the idea)

If you want more code around them, like table cells or whatever you'd do it in the foreach loop like:

$blah = split(",", $row[images]);
$stringading = "tr";
foreach ($blah as $beep) {
$stringading .= "<td><img src=\"" . $beep . "\" /></td>";
}
$stringading .= "</tr>";

Can't edit that ^ post for some reason. Can edit other posts fine, but trying to edit that one results in a long wait and then a generic beehive 'error: retry' page thing.

That shows all the images (cheer)

 

But it breaks everything else and nothing else outputs :C

So I see. It's getting stuck in a while loop which basically reads:

function func_name()
{
    while (1) {

        if ($condition) {
            func_name();
        }

        if ($other_condition) {
            break; // exit the while loop
        }
    }
}

So it's recursively calling itself, in a infinite loop. It's code Andy wrote and bless his cotton socks he really did like using variables like $a, $b, $i, $j, $tmp, which while I'm sure have meaning to him mean fuck all to me.

Because I can't work it out, I'll remove it :Y

It's probably not important any how.

:'D

Paste your code.

(Re-using an existing eighteen month old thread makes it more difficult to jump back to the start, and has no benefit when you're asking an entirely different question.)


Anyway, if you want to convert commas to image tags, then you can do it like this:

$string = '<img src="' . replace( ',' , '" /><img src="' , $string ) . '" />';

or like this:

$string = preg_replace( '(?:^|,)([^,]+)' , '<img src="$1" />' , $string );

(That one having the benefit of only needing to specifying the surrounding code once, although it may confuse people that don't understand regex.)


However, in most cases I'd probably do something similar to what Lucy posted (split and then foreach), because it makes things more flexible.
Any problems you're having there are most likely examples of why tables are not the right way to do layouts. :P

Don't suppose that code was in some way responsible for code formatting?

1. I will start a new thread next time I want coding help :C
2. I really need to learn how to use regex stuff.
3. Nothing wrong with tables (maybe). But I doubt they're the issue here.

There you go..

<?php
mysql_connect("localhost","user","pass");
mysql_select_db("cogs");

$car = $_GET['car'];

$query  = "SELECT * FROM cars WHERE carcode = '$car' ";
$result = mysql_query($query);

while($row = mysql_fetch_array($result, MYSQL_ASSOC))

$blah = split(",", $row[images]);
foreach ($blah as $beep) {
$stringading .= "<img src=\"" . $beep . "\" />";
}

echo "

<table>
    <tr>
    <th rowspan='5'><a href='#'><img src='./photos/{$row[thumb]}' /></a>
    <br />
    " . $stringading . "
    <br />
    <td colspan='2' width='300px'><a href='car.php?car={$row[carcode]}'>{$row[title]}</a></td>
    </tr>
    <tr>
    <td width='250px'>Year - {$row[year]}<br />
                      Mileage - {$row[mileage]}<br />
                      Engine - {$row[engine]}<br />
                      Fuel - {$row[fuel]}<br />
                      Gearbox - {$row[gearbox]}<br />     </td>
    <td width='250px'>Body/Doors - <br />
                      Colour - {$row[colour]}<br />
                      MOT - {$row[mot]}<br />
                      Tax - {$row[tax]}<br /></td>
    </tr>
    <tr>
    <td colspan='2'>{$row[extra]}</td>
    </tr>
    <tr>
    <td colspan='2' align='right' valign='bottom'><b>&pound;{$row[price]}</b></td>
    </tr>
    <tr>
    <td colspan='2'>FULL WIDTH</td>
    </tr>
</table>

         ";
?>

Everyone really needs to learn regex, though it seems to be eternally relegated to people's todo list. :(

Anyway, looking at the latest posted code, problem is that the while loop doesn't have a brace block - when it was a single statement (echo) it worked, but now it's multiple statements you need to group them.

while($row = mysql_fetch_array($result, MYSQL_ASSOC))

{

    $blah = split(",", $row[images]);

    foreach ($blah as $beep)

    {

        $stringading .= "<img src=\"" . $beep . "\" />";

    }



    echo "

    ...

         ";

}

?>

I agree on the regex front. It seems to have been the fix for loads of stuff I've asked on here.

 

Also (hug) the extra braces worked!